Merge pull request #238 from ConsumerDataStandardsAustralia/maintenan…

…ce/414

Standards Maintenance/414

slate/source/includes/_banking_apis.md.erb

@@ -10,6 +10,10 @@ This specification defines the APIs for Data Holders exposing Banking endpoints.
 <tr><td><a href='./includes/swagger/cds_banking.yaml'>Banking OpenAPI Specification (YAML)</a></td></tr>
 </table>
 
+```diff
+Fixed the 'BankingTransactionDetail' schema to treat the 'extendedDescription' as conditional
+```
+
 <%= partial "includes/cds_banking.md" %>
 <%= partial "includes/banking/_product_categories.md" %>
 <%= partial "includes/banking/_product_components.md" %>

slate/source/includes/releasenotes/releasenotes.1.19.0.html.md

@@ -24,7 +24,6 @@ This release addresses the following change requests raised on [Standards Mainte
 
 - [Standards Maintenance Issue 529: CX - Energy Data Language Standards - NMI and Scheduled Payments](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/529)
 
-
 ### Decision Proposals
 
 This release addresses the following Decision Proposals published on [Standards](https://github.com/ConsumerDataStandardsAustralia/standards/issues):

slate/source/includes/releasenotes/releasenotes.1.20.0.html.md

@@ -20,6 +20,7 @@ This release addresses the following minor defects raised on [Standards Staging]
 
 This release addresses the following change requests raised on [Standards Maintenance](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues):
 
+- [Standards Maintenance Issue 414: Properties in BankingTransactionDetail objects](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/414)
 - [Standards Maintenance Issue 506: Energy error codes for issues in data received by DH from SDH](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/506)
 - [Standards Maintenance Issue 526: Energy / Get DER for Service Point - allow for no data](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/526)
 - [Standards Maintenance Issue 524: EnergyDerRecord - mandatory values not available in AEMO's DER register](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/524)
@@ -48,6 +49,7 @@ This release addresses the following Decision Proposals published on [Standards]
 
 |Change|Description|Link|
 |------|-----------|----|
+| BankingTransactionDetail schema fix | [**Standards Maintenance #414**](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/414): Fixed the BankingTransactionDetail object to correctly show it as conditional based on the extensionUType. | [BankingTransactionDetail](../../#tocSbankingtransactiondetail) |
 | Energy schema | [**Standards Maintenance #526**](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/526): <ul><li>Changed type of `EnergyDerRecord.availablePhasesCount` and `EnergyDerRecord.installedPhasesCount` fields to `NaturalNumber`</li><li>Updated description of `approvedCapacity`, `availablePhasesCount` and `installedPhasesCount` in `EnergyDerRecord` to note a 0 value indicates no DER record is available</li></ul> | [Energy Schema](../../#energy-apis) |
 | Energy schema | [**Standards Maintenance #524**](https://github.com/ConsumerDataStandardsAustralia/standards-maintenance/issues/524): Updated description of `inverterDeviceCapacity`, `derDevices.nominalRatedCapacity` and `derDevices.nominalStorageCapacity` fields in `EnergyDerRecord.acConnections` noting 0 as the default when value not known | [Energy Schema](../../#energy-apis) |
 | Draft Telco standards | [**Decision Proposal #275**](https://github.com/ConsumerDataStandardsAustralia/standards/issues/275): Publish of draft (ie. non-binding) technical standards for the Telco sector for holistic review | [Telco Schema](../../#telco-apis) |

swagger-gen/api/cds_banking.json

@@ -4710,20 +4710,20 @@
                   },
                   "extensionUType": {
                     "type": "string",
-                    "description": "Optional extended data provided specific to transaction originated via NPP",
+                    "description": "Optional extended data specific to transactions originated via NPP",
                     "enum": [
                       "x2p101Payload"
                     ]
                   },
                   "x2p101Payload": {
-                    "required": [
+                    "x-conditional": [
                       "extendedDescription"
                     ],
                     "type": "object",
                     "properties": {
                       "extendedDescription": {
                         "type": "string",
-                        "description": "An extended string description. Only present if specified by the extensionUType field"
+                        "description": "An extended string description. Required if the extensionUType field is `x2p101Payload`"
                       },
                       "endToEndId": {
                         "type": "string",
@@ -4746,7 +4746,7 @@
                 "x-conditional": [
                   "payer",
                   "payee",
-                  "extendedDescription"
+                  "x2p101Payload"
                 ]
               }
             }