Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Iteration 17 Holistic Feedback #612

Closed
CDR-API-Stream opened this issue Sep 12, 2023 · 25 comments
Closed

Maintenance Iteration 17 Holistic Feedback #612

CDR-API-Stream opened this issue Sep 12, 2023 · 25 comments
Labels
Non-breaking change A change that is not expected to result in a new endpoint version.
Milestone

Comments

@CDR-API-Stream
Copy link
Collaborator

This change request has been created to simplify the raising of minor changes, such as text corrections or description clarifications, that are not really material to the standards but do have a real impact on readability and clarity.

Please raise any such suggestions that you would like included in Maintenance Iteration 17 and the DSB will review them. If a suggestion is a material change a dedicated CR will be raised.

@nils-work
Copy link
Member

Item from MI 16 holistic feedback - #599 (comment)

The endpoint versioning schedule is incorrect for the CDR Arrangement Revocation End Point.

@perlboy
Copy link

perlboy commented Sep 14, 2023

Non Normative example for Discovery document seems to use a string for the code_challenge_methods when it is a JSON array. For example:
... "code_challenge_methods_supported": "S256", ...

I don't believe singletons are supported for this attribute. Also, RFC7636 isn't in the Normative References list.

@nils-work
Copy link
Member

There is a typo in the description of the kid property in the JWK section of Register APIs.
Proposing the following changes for clarity (insert 'to be', delete 'to'):

The "kid" (key ID) parameter is partially used to match a specific key. Note the "kid" parameter is not guaranteed to be unique and additional parameters should be used to progressively to identify a key within a set

@nils-work
Copy link
Member

The maturityInstructions property has three enumerated values defined in the BankingTermDepositAccount schema, but only the most recently added value HOLD_ON_MATURITY has a detailed description in the Product & Account Components section.

A link to the supporting information could be added to the maturityInstructions description in the schema, and the missing values added to the table.

New row detail for consideration -

Value Description Use of additionalValue Field
PAID_OUT_AT_MATURITY Funds are to be paid out at maturity NA
ROLLED_OVER Funds are to be rolled over at maturity NA

@nils-work
Copy link
Member

There are references to three incorrect field labels in the property descriptions of BankingProductRateTierV3.

These changes are required -

  • tierValueMinimum should refer to minimumValue
  • tierValueMaximum should refer to maximumValue
  • tierUnitOfMeasure should refer to unitOfMeasure

@nils-work nils-work moved this from Full Backlog to Iteration Candidates in Data Standards Maintenance Sep 20, 2023
@nils-work
Copy link
Member

There are a few minor differences in the naming of Register endpoints in the documentation.
These could be aligned:
image

@nils-work
Copy link
Member

The text:

Refer also to Future Dated obligations

in the Amending Authorisation Standards section can be removed as the obligation date for these requirements has passed.

@nils-work
Copy link
Member

Add a link to the Obligation Dates Schedule from the Future Dated Obligations section.

@CDR-Engagement-Stream
Copy link
Contributor

CDR-Engagement-Stream commented Sep 29, 2023

Request for update to the Consumer Experience Guidelines link in the CDS.

From here: https://consumerdatastandardsaustralia.github.io/standards/#consumer-experience

image

Change the link to direct reference to the CX Guidelines.

Change from:
<a href="https://consumerdatastandards.gov.au/guidelines-and-conventions/consumer-experience-guidelines/">

To:
<a href="https://cx.cds.gov.au/">

Link to line: https://github.com/ConsumerDataStandardsAustralia/standards/blob/877417aaff0a44a195c6893c630d4340e757d7d6/docs/includes/cx#L6C2-L6C2

Edit: formatting.

@nils-work
Copy link
Member

To reflect the changes in the error reporting structure from Get Metrics v3, to v4 and v5 -

Update the Description of the errors property of ResponseMetricsListV4 and ResponseMetricsListV5:

- Number of calls resulting in error due to server execution over time
+ Number of calls resulting in error, over time

Update the italic introductory text under the heading of ErrorMetricsV2 (in Get Metrics v4 and v5):

- Number of calls resulting in error due to server execution over time
+ Number of calls resulting in error, over time

Update the following property descriptions in ErrorMetricsV2 (in Get Metrics v4 and v5):

- Number of calls resulting in error due to server execution over time for unauthenticated endpoints
+ Number of calls resulting in error for unauthenticated endpoints
- Number of calls resulting in error due to server execution over time for authenticated endpoints
+ Number of calls resulting in error for authenticated endpoints

@anzbankau
Copy link

anzbankau commented Oct 5, 2023

Hi @nils-work,

As part of these corrections (earlier #612 (comment)):

There are references to three incorrect field labels in the property descriptions of BankingProductRateTierV3.

These changes are required -

  • tierValueMinimum should refer to minimumValue
  • tierValueMaximum should refer to maximumValue
  • tierUnitOfMeasure should refer to unitOfMeasure

Could you please correct the minimumValue and maximumValue descriptions that still refer to tierUnitOfMeasure when the referenced property was subsequently renamed to unitOfMeasure.

@anzbankau
Copy link

anzbankau commented Oct 6, 2023

Hi @nils-work,

As mentioned in our comment CP614 - Definition of PERCENT in BankingProductRateTierV3:

(While the Number data type has the Description "A standard floating point number. Can be positive, negative or zero", the examples include the integer 10, so perhaps the description needs to be expanded.)

Assuming there hasn't been guidance to ignore the example of 10 for Number, we suggest the following description:

  • An integer or decimal number. Can be positive, negative or zero.

Note: Since JSON is representational rather than for storage, 'decimal' should be used in the description rather than 'floating point'.

If Number was not intended to include integers, perhaps a review (only) of the data type hierarchy for numeric data would be timely. We're not suggesting changes as there would be significant implementation impacts. The traditional hierarchy:

  • Number:
    • Integer:
      • 0
      • PositiveInteger
      • NegativeInteger
    • Decimal: [0.0, PositiveDecimal, NegativeDecimal]

... has been extended in Common Field Types with the useful union:

  • NaturalNumber: [ 0 | PositiveInteger ]

... but there's also this interesting modification (for which an alternative name would be hard to provide):

  • NegativeInteger: [ 0 | NegativeInteger ]

Thanks.

@kirkycdr kirkycdr moved this from Iteration Candidates to In Progress: Design in Data Standards Maintenance Nov 1, 2023
@nils-work
Copy link
Member

Thanks for raising this @perlboy, the first part was resolved in v1.27.0 -

Non Normative example for Discovery document seems to use a string for the code_challenge_methods when it is a JSON array. For example: ... "code_challenge_methods_supported": "S256", ...

and RFC7636 is linked from the [PKCE] entry, but not by itself with the other RFC entries -

I don't believe singletons are supported for this attribute. Also, RFC7636 isn't in the Normative References list.

@CDR-Engagement-Stream
Copy link
Contributor

CDR-Engagement-Stream commented Nov 15, 2023

Update link to the Data Standards Body (DSB) under Introduction.

image

Current link goes to: https://www.directory.gov.au/portfolios/treasury/data-standards-body (404 - Access denied)

I think the original page has been deprecated. Now there is no new or replacement.

Proposed new link: https://www.legislation.gov.au/Details/F2021N00038

Edit: changed proposed link

@kirkycdr
Copy link

There are references to three incorrect field labels in the property descriptions of BankingProductRateTierV3.

These changes are required -

  • tierValueMinimum should refer to minimumValue
  • tierValueMaximum should refer to maximumValue
  • tierUnitOfMeasure should refer to unitOfMeasure

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@89314f9

ConsumerDataStandardsAustralia/standards-staging@349180a

@kirkycdr
Copy link

Request for update to the Consumer Experience Guidelines link in the CDS.

From here: https://consumerdatastandardsaustralia.github.io/standards/#consumer-experience

image

Change the link to direct reference to the CX Guidelines.

Change from: <a href="https://consumerdatastandards.gov.au/guidelines-and-conventions/consumer-experience-guidelines/">

To: <a href="https://cx.cds.gov.au/">

Link to line: https://github.com/ConsumerDataStandardsAustralia/standards/blob/877417aaff0a44a195c6893c630d4340e757d7d6/docs/includes/cx#L6C2-L6C2

Edit: formatting.

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@0156249

@kirkycdr
Copy link

The text:

Refer also to Future Dated obligations

in the Amending Authorisation Standards section can be removed as the obligation date for these requirements has passed.

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@25d7069

@kirkycdr
Copy link

Thanks for raising this @perlboy, the first part was resolved in v1.27.0 -

Non Normative example for Discovery document seems to use a string for the code_challenge_methods when it is a JSON array. For example: ... "code_challenge_methods_supported": "S256", ...

and RFC7636 is linked from the [PKCE] entry, but not by itself with the other RFC entries -

I don't believe singletons are supported for this attribute. Also, RFC7636 isn't in the Normative References list.

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@71734da

@kirkycdr
Copy link

Update link to the Data Standards Body (DSB) under Introduction.

image

Current link goes to: https://www.directory.gov.au/portfolios/treasury/data-standards-body (404 - Access denied)

I think the original page has been deprecated. Now there is no new or replacement.

Proposed new link: https://www.legislation.gov.au/Details/F2021N00038

Edit: changed proposed link

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@3381935

@kirkycdr
Copy link

There are a few minor differences in the naming of Register endpoints in the documentation. These could be aligned: image

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@6565dfe

@kirkycdr
Copy link

Add a link to the Obligation Dates Schedule from the Future Dated Obligations section.

This has been staged for review:
ConsumerDataStandardsAustralia/standards-staging@1e61195

@kirkycdr
Copy link

The maturityInstructions property has three enumerated values defined in the BankingTermDepositAccount schema, but only the most recently added value HOLD_ON_MATURITY has a detailed description in the Product & Account Components section.

A link to the supporting information could be added to the maturityInstructions description in the schema, and the missing values added to the table.

New row detail for consideration -

Value Description Use of additionalValue Field
PAID_OUT_AT_MATURITY Funds are to be paid out at maturity NA
ROLLED_OVER Funds are to be rolled over at maturity NA

This has been staged for review :
ConsumerDataStandardsAustralia/standards-staging@061bf45

@kirkycdr
Copy link

Hi @nils-work,

As mentioned in our comment CP614 - Definition of PERCENT in BankingProductRateTierV3:

(While the Number data type has the Description "A standard floating point number. Can be positive, negative or zero", the examples include the integer 10, so perhaps the description needs to be expanded.)

Assuming there hasn't been guidance to ignore the example of 10 for Number, we suggest the following description:

  • An integer or decimal number. Can be positive, negative or zero.

Note: Since JSON is representational rather than for storage, 'decimal' should be used in the description rather than 'floating point'.

If Number was not intended to include integers, perhaps a review (only) of the data type hierarchy for numeric data would be timely. We're not suggesting changes as there would be significant implementation impacts. The traditional hierarchy:

  • Number:

    • Integer:

      • 0
      • PositiveInteger
      • NegativeInteger
    • Decimal: [0.0, PositiveDecimal, NegativeDecimal]

... has been extended in Common Field Types with the useful union:

  • NaturalNumber: [ 0 | PositiveInteger ]

... but there's also this interesting modification (for which an alternative name would be hard to provide):

  • NegativeInteger: [ 0 | NegativeInteger ]

Thanks.

This has been staged for review:

ConsumerDataStandardsAustralia/standards-staging@1cdef9f

@kirkycdr
Copy link

To reflect the changes in the error reporting structure from Get Metrics v3, to v4 and v5 -

Update the Description of the errors property of ResponseMetricsListV4 and ResponseMetricsListV5:

- Number of calls resulting in error due to server execution over time
+ Number of calls resulting in error, over time

Update the italic introductory text under the heading of ErrorMetricsV2 (in Get Metrics v4 and v5):

- Number of calls resulting in error due to server execution over time
+ Number of calls resulting in error, over time

Update the following property descriptions in ErrorMetricsV2 (in Get Metrics v4 and v5):

- Number of calls resulting in error due to server execution over time for unauthenticated endpoints
+ Number of calls resulting in error for unauthenticated endpoints
- Number of calls resulting in error due to server execution over time for authenticated endpoints
+ Number of calls resulting in error for authenticated endpoints

This has been staged for review:

ConsumerDataStandardsAustralia/standards-staging@eff33a6

@nils-work nils-work added this to the v1.29.0 milestone Nov 24, 2023
@kirkycdr kirkycdr moved this from In Progress: Design to In Progress: Staging in Data Standards Maintenance Dec 7, 2023
@nils-work nils-work moved this from In Progress: Staging to Awaiting Chair Approval in Data Standards Maintenance Dec 21, 2023
@nils-work nils-work moved this from Awaiting Chair Approval to Done in Data Standards Maintenance Dec 21, 2023
nils-work added a commit to ConsumerDataStandardsAustralia/standards-staging that referenced this issue Jan 16, 2024
nils-work added a commit to ConsumerDataStandardsAustralia/standards-staging that referenced this issue Jan 16, 2024
Documentation update from MI17 holistic thread but not included in release 1.29.0.
Addresses: ConsumerDataStandardsAustralia/standards-maintenance#612 (comment)
@CDR-API-Stream
Copy link
Collaborator Author

Standards version 1.29.0 was published on 21/12/2023 incorporating changes from MI17.

nils-work added a commit to ConsumerDataStandardsAustralia/standards-staging that referenced this issue Feb 21, 2024
nils-work added a commit to ConsumerDataStandardsAustralia/standards-staging that referenced this issue Feb 21, 2024
Documentation update from MI17 holistic thread which was not included in release 1.29.0.
Addresses: ConsumerDataStandardsAustralia/standards-maintenance#612 (comment)
JamesMBligh added a commit to ConsumerDataStandardsAustralia/standards that referenced this issue Feb 28, 2024
* Standards Release 1.29.1# Changed version number in intro markdown and master swagger files. Added entry for new version in changelog table. Create new empty releasenotes file. Added entry for previous version in archives table. Updated new_version_setup utils file to accept -ndiff command line parameter to not remove diff statements and fixed small bugs

* Fix typos to clarify documentation

Addresses: ConsumerDataStandardsAustralia/standards-maintenance#612 (comment)

* Removed text referring to historical FDOs

Documentation update from MI17 holistic thread which was not included in release 1.29.0.
Addresses: ConsumerDataStandardsAustralia/standards-maintenance#612 (comment)

* Standards Staging Issue #368: Fixed known issue of incorrect version numbers of Get Bulk Billing and Get Billing For Specific Accounts APIs

* Rebuild and check

* Rebuild

---------

Co-authored-by: Hemang Rathod <[email protected]>
Co-authored-by: Nils Berge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking change A change that is not expected to result in a new endpoint version.
Projects
Status: Done
Development

No branches or pull requests

6 participants