-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard appears to redefine requirements for private_key_jwt authentication #535
Comments
Just to add some additional data to this issue, as mentioned in the CDR Maintenance Iteration call on the 05/10/2022, when using OIDF's Conformance Suite to test a Data Holder Auth Server's conformance to FAPI, the
Therefore, if a Data Holder Auth Server follows the Consumer Data Standards and requires a |
This was discussed in the last MI call. No objections were raised with make the client_id optional. In doing so that would achieve successful FAPI conformance testing. It was noted that if the change is adopted that the obligation date for the change should be bundled with other uplift work such as FAPI 2.0. |
Discussed in last week’s maintenance iteration call the primary driver to bring this change forward is to facilitate FAPI 1.0 certification testing. The change being proposed is a relaxation of the REQUIRED statement to OPTIONAL. This defers to the upstream RFC7521 standard. The area affected is the Private Key JWT Client Authentication section of the data standards. Considerations in regards to this change:
Future Dated Obligation Feedback is requested for adoption of a future obligation date. Given the maintenance iteration is mid-way through, it is proposed that 13/11/2023 be set for the obligation date (Y23 #5 obligation milestone). |
As discussed in the maintenance iteration call, both Data Holders and the CDR Register require clients to authenticate using the Private Key JWT method under certain scenarios. The original proposal focused on the Data Holder changes, however there is also the consideration of changing the CDR Register.
The driver for this change is to allow Data Holders to pass FAPI testing certification. There is less of a driver for the CDR Register to make this change because ADRs are already integrated. There may be a benefit to ADRs calling the CDR Register if the commonly used client libraries offer limited support for including the The other benefit for the CDR Register following suit is consistency. That said, the ACCC would need to weigh these potential benefits against their existing implementation cost and the cost to change. Change ImpactGiven that ADRs are currently required to send the
Phasing inDuring the MI call, an option was presented to phase in Data Holder supportability. The suggestion was to vary the REQUIRED condition to RECOMMENDED before setting it to OPTIONAL to permit Data Holders to progressively migrate.
In doing so, any ADR that does not send the During the transtion time it would be expected that ADRs would continue to send the Similarly, the same logic can be applied to the CDR Register (and clients calling the CDR ) if it seeks to align to the upstream normative standards. It would be expected that CTS would continue to test clients are presenting the Given ADRs (and the CDR Register when calling the Data Holder) are currently required to provide the Transition periodIf the assumptions above hold correct, then the proposal is that the "RECOMMENDED" requirement be introduced without a future dated obligation whilst the "OPTIONAL" requirement be introduced with a 13/11/2023 obligation date Y23 #5 obligation milestone. Wording of proposed changes
Whilst RFC6749 states that
Further, the introductory statement be modified from:
to:
|
The ACCC supports making the client_id optional to align to upstream RFC7521 standard and support FAPI certification by participants as proposed in the comment Standard appears to redefine requirements for private_key_jwt authentication · Issue #535 · ConsumerDataStandardsAustralia/standards-maintenance. The ACCC confirms that the Register changes required to support this standards change are achievable by 13/11/2023 provided the relevant changes are published in the Consumer Data Standards by the 12th of May. |
Changes for this issue were staged here and incorporated into Standards version 1.24.0. |
Description
As highlighted in Sandbox Issue 4 the Standards appear to have conflicting information in that they state that for private key client authentication:
But then indicate:
This appears to be in conflict with the underlying spec linked from OIDC, OAuth Assertions which includes:
Essentially the Standards seem to add the
client_id
requirement over the top of the underlying spec?Area Affected
Client Authentication
Change Proposed
The Standards seem to be restating client authentication and in doing so seem to be redefining it.
Suggest one of the following:
private_key_jwt
and simply defer to the upstream Standard (makingclient_id
optional as a parameter in the process)DSB Proposed Solution
The current DSB proposal for this issue is in this comment
The text was updated successfully, but these errors were encountered: