Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hsqldb to 2.7.1 #1494

Closed
wants to merge 7 commits into from
Closed

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Oct 12, 2022

Signed-off-by: Sally MacFarlane [email protected]

  • Update hsqldb

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
Copy link
Contributor Author

Getting 3 errors from running ./gradlew :tests:acceptance-test:compileTestJava locally - to do with something I don't understand in module-info.test

/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible
import org.hsqldb.persist.HsqlProperties;
                 ^
  (package org.hsqldb.persist is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)
/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:5: error: package org.hsqldb.server is not visible
import org.hsqldb.server.Server;
                 ^
  (package org.hsqldb.server is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)
/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:6: error: package org.hsqldb.server is not visible
import org.hsqldb.server.ServerAcl;
                 ^
  (package org.hsqldb.server is declared in module org.hsqldb, but module tessera.acceptance.tests does not read it)

@macfarla
Copy link
Contributor Author

with extra work I am down to one error


/Users/sallymacfarlane/workspace/tessera/tests/acceptance-test/src/test/java/db/HsqlDatabaseServer.java:4: error: package org.hsqldb.persist is not visible
import org.hsqldb.persist.HsqlProperties;
                 ^
  (package org.hsqldb.persist is declared in module org.hsqldb, which does not export it)

@macfarla
Copy link
Contributor Author

^ so in test we are using a class org.hsqldb.persist.HsqlProperties which is not exported by the org.hsqldb module - not sure if there's a way around this

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
Copy link
Contributor Author

luckily there is an overloaded method that accepts java.util.Properties and wraps them into HsqlProperties internally.

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla changed the title update hsqldb to 2.7.0 update hsqldb to 2.7.1 Oct 31, 2022
@macfarla
Copy link
Contributor Author

2.7.1 is out so suppression can be removed

@macfarla macfarla self-assigned this Oct 31, 2022
@macfarla
Copy link
Contributor Author

macfarla commented Nov 1, 2022

current failures seem to boil down to this

Error occurred during initialization of boot layer
java.lang.module.FindException: Module jnacl not found, required by tessera.encryption.jnacl

Signed-off-by: Sally MacFarlane <[email protected]>
@namtruong namtruong mentioned this pull request Nov 12, 2022
2 tasks
@Krish1979
Copy link
Collaborator

closing this as it is fixed with #1498

@Krish1979 Krish1979 closed this Nov 13, 2022
@macfarla macfarla deleted the hsqldb-sup branch November 14, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants