Added GetPendingDeposits #9110
Merged
Added GetPendingDeposits #9110
+448
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses ethereum/beacon-APIs#500 Attempting to access this data prior to electra will fail with a 400. Signed-off-by: Paul Harris <[email protected]>
lucassaldanha
approved these changes
Feb 12, 2025
| .description( | ||
| "Returns pending deposits for state with given 'stateId'. Should return 400 if requested before electra.") | ||
| .pathParam(PARAMETER_STATE_ID) | ||
| .tags(TAG_BEACON, TAG_EXPERIMENTAL) |
There was a problem hiding this comment.
i can remove it but its not currently approved is all
| if (!maybeStateAndMetadata | ||
| .get() | ||
| .getMilestone() | ||
| .isGreaterThanOrEqualTo(SpecMilestone.ELECTRA)) { |
There was a problem hiding this comment.
NIT: I think we need a isLessThan() method for our Milestone check... This would read much better as isLessThan(SpecMilestone.ELECTRA) (and without negating the whole expression).
There was a problem hiding this comment.
thats what i looked for first, i guess i could change it
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses ethereum/beacon-APIs#500
Attempting to access this data prior to electra will fail with a 400.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog