Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max gossip compressed size #8924

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
### Bug Fixes
- Updated the gas change check for block building so that warnings only get raised if the change is off spec.
- Fixed an issue with the `/eth/v1/config/spec` API not returning all previously included configuration parameters.

- Increase the maximum size of a compressed message for libp2p to ensure uncompressed blocks can grow to max size.
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,10 @@ private static void addGossipParamsDValues(

private static void addGossipParamsMaxValues(
final NetworkingSpecConfig networkingSpecConfig, final GossipParamsBuilder builder) {
final int gossipMaxSize = networkingSpecConfig.getGossipMaxSize();
final int compressedMaxGossipSize = 32 + gossipMaxSize + (gossipMaxSize / 6);
builder
.maxGossipMessageSize(networkingSpecConfig.getGossipMaxSize())
.maxGossipMessageSize(compressedMaxGossipSize)
.maxPublishedMessages(1000)
.maxTopicsPerPublishedMessage(1)
.maxSubscriptions(MAX_SUBSCRIPTIONS_PER_MESSAGE)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void createGossipParams_checkZeroDsSucceed() {
public void createGossipParams_setGossipMaxSizeFromNetworkSpecConfig() {
final GossipConfig gossipConfig = GossipConfig.builder().build();
final NetworkingSpecConfig networkingSpecConfig = spy(spec.getNetworkingConfig());
final int expectedGossipMaxSize = networkingSpecConfig.getGossipMaxSize();
final int expectedGossipMaxSize = 12233418;
reset(networkingSpecConfig);

final GossipParams gossipParams =
Expand Down
Loading