Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant migrate method from the Database interface #8657

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Remove redundant migrate method from the Database interface #8657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae1f0d1
Remove redundant method from the Database interface
gfukushima Sep 30, 2024
4995d65
Merge branch 'master' into remove-migrate-method
gfukushima Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...es/chainstorage/src/main/java/tech/pegasys/teku/services/chainstorage/StorageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ protected SafeFuture<?> doStart() {
config);
database = dbFactory.createDatabase();

database.migrate();

final SettableLabelledGauge pruningTimingsLabelledGauge =
SettableLabelledGauge.create(
serviceConfig.getMetricsSystem(),
Expand Down
2 changes: 0 additions & 2 deletions storage/src/main/java/tech/pegasys/teku/storage/server/Database.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ default Stream<SlotAndBlockRootAndBlobIndex> streamBlobSidecarKeys(final UInt64

long getNonCanonicalBlobSidecarColumnCount();

void migrate();

Optional<Checkpoint> getAnchor();

Optional<Checkpoint> getJustifiedCheckpoint();
Expand Down
3 changes: 0 additions & 3 deletions storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/KvStoreDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,6 @@ public long getNonCanonicalBlobSidecarColumnCount() {
return dao.getNonCanonicalBlobSidecarColumnCount();
}

@Override
public void migrate() {}

@Override
public void deleteHotBlocks(final Set<Bytes32> blockRootsToDelete) {
try (final HotUpdater updater = hotUpdater()) {
Expand Down
3 changes: 0 additions & 3 deletions storage/src/main/java/tech/pegasys/teku/storage/server/noop/NoOpDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,6 @@ public long getNonCanonicalBlobSidecarColumnCount() {
return 0L;
}

@Override
public void migrate() {}

@Override
public Optional<Checkpoint> getAnchor() {
return Optional.empty();
Expand Down