Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max epoch activation churn limit for Deneb #7522

Merged

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Sep 18, 2023

PR Description

Fixed Issue(s)

fixes #7520

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov
Copy link
Contributor Author

Waiting for v1.4.0-beta.2 release of consensus-spec-tests

@StefanBratanov StefanBratanov force-pushed the max_epoch_activation_churn_limit branch from 3f98c8e to c226bf4 Compare September 19, 2023 03:45
@StefanBratanov
Copy link
Contributor Author

Waiting for v1.4.0-beta.2 release of consensus-spec-tests

PR updated with latest version

@StefanBratanov StefanBratanov force-pushed the max_epoch_activation_churn_limit branch from 13b6f72 to 9b59427 Compare September 21, 2023 02:41
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just want to double-check if there is any config param breaking change.
Like maxPerEpochActivationChurnLimit becomes mandatory and a VC with this PR doesn't start against a BN without this PR

@StefanBratanov
Copy link
Contributor Author

LGTM. I just want to double-check if there is any config param breaking change. Like maxPerEpochActivationChurnLimit becomes mandatory and a VC with this PR doesn't start against a BN without this PR

Good point. Thanks for checking. Shouldn't break until both are on Deneb in which case, both VC and BN should have been updated anyways.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 78a929f into Consensys:master Sep 21, 2023
@StefanBratanov StefanBratanov deleted the max_epoch_activation_churn_limit branch September 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max epoch activation churn limit (EIP-7514)
2 participants