-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max epoch activation churn limit for Deneb #7522
Add max epoch activation churn limit for Deneb #7522
Conversation
Waiting for v1.4.0-beta.2 release of consensus-spec-tests |
3f98c8e
to
c226bf4
Compare
PR updated with latest version |
13b6f72
to
9b59427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just want to double-check if there is any config param breaking change.
Like maxPerEpochActivationChurnLimit
becomes mandatory and a VC with this PR doesn't start against a BN without this PR
Good point. Thanks for checking. Shouldn't break until both are on Deneb in which case, both VC and BN should have been updated anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
getValidatorActivationChurnLimit
inBeaconStateAccessors
and overrode it inBeaconStateAccessorsDeneb
MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT
toSpecConfigDeneb
to all config files, which have deneb config params already.--Xfork-choice-proposer-boost-uniqueness-enabled
to true by defaultv1.4.0-beta.2-hotfix
Fixed Issue(s)
fixes #7520
Documentation
doc-change-required
label to this PR if updates are required.Changelog