[Decoupling] Unblinding of SignedBlockContainer (part 3) #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
reviewed
May 23, 2023
...main/java/tech/pegasys/teku/validator/coordinator/performance/DefaultPerformanceTracker.java
Outdated
Show resolved
Hide resolved
...on/validator/src/main/java/tech/pegasys/teku/validator/coordinator/AbstractBlockFactory.java
Show resolved
Hide resolved
.../pegasys/teku/spec/datastructures/blobs/versions/deneb/SignedBlobSidecarsUnblinderDeneb.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
unblinding_signed_block_container
branch
from
3ea6ce5 to
54ca43f
Compare
tbenr
reviewed
May 23, 2023
.../pegasys/teku/spec/datastructures/blobs/versions/deneb/SignedBlobSidecarsUnblinderDeneb.java
Outdated
Show resolved
Hide resolved
tbenr
approved these changes
May 23, 2023
.../pegasys/teku/spec/datastructures/blobs/versions/deneb/SignedBlobSidecarsUnblinderDeneb.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
unblinding_signed_block_container
branch
from
5f6bae7 to
2b67d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
unblindSignedBlockIfBlindedinBlockFactoryDenebwhich deals with unblinding of the list ofBlindedBlobSidecarSignedBlobSidecarsUnblinderunblindSignedBlindedBlobSidecarsunder spec in similar pattern asunblindSignedBeaconBlockNext final part:
Fixed Issue(s)
next final part will fix couple of tasks in #6822
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog