Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge getPayloadV3 and getBlobsBundleV1 (part 2) #7101

Merged
merged 5 commits into from
May 5, 2023
Merged

Merge getPayloadV3 and getBlobsBundleV1 (part 2) #7101

merged 5 commits into from
May 5, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 4, 2023 •
edited
Loading

PR Description

Continuing from part 1: #7096

Follows the dataclasses specified in ethereum/consensus-specs#3341

  • Created GetPayloadResponse data class
  • Return GetPayloadResponse in the ExecutionLayerChannel and the ExecutionClientHandler
  • Modify the ExecutionLayerBlockProductionManagerImpl to not use the BLOBS_BUNDLE_DUMMY for local block production
  • Modify the ExecutionLayerChannelStub to return GetPayloadResponse

Fixed Issue(s)

fixes the Engine API task in #6822

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor

tbenr commented May 5, 2023 •
edited
Loading

what about 8ae4561 ?

moving away from milestone-specific versions and become more feature based allows us to be more transparent, which perfectly apply in this case

@StefanBratanov
Copy link
Contributor Author

what about 8ae4561 ?

moving away from milestone-specific versions and become more feature based allows us to be more transparent, which perfectly apply in this case

Yeah I like it. I wasn't sure about that part. Looks cleaner.

tbenr
tbenr approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 7a273fd into Consensys:master May 5, 2023
@StefanBratanov StefanBratanov deleted the merge_get_payload_get_blobs_bundle_2 branch May 5, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @tbenr