Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated blinded block blinding and unblinding for capella #6495

Merged
merged 8 commits into from
Nov 24, 2022

Conversation

rolfyone
Copy link
Contributor

  • test cases were not showing a failure to serialize due to the new field, fixed by serializing to json
  • changed to alow more than one field being blinded and unblinded

partially addresses #6296

Signed-off-by: Paul Harris [email protected]

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

 - test cases were not showing a failure to serialize due to the new field, fixed by serializing to json
 - changed to alow more than one field being blinded and unblinded

 partially addresses Consensys#6296

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone marked this pull request as ready for review November 23, 2022 23:14
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some suggested bits that could be tidied up.

@rolfyone rolfyone merged commit c8a4c91 into Consensys:master Nov 24, 2022
@rolfyone rolfyone deleted the 6296 branch November 24, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants