-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw unchecked exceptions when creating requests for builders #6111
Don't throw unchecked exceptions when creating requests for builders #6111
Conversation
...onclient/src/main/java/tech/pegasys/teku/ethereum/executionclient/rest/OkHttpRestClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Even if its only in test code, pinging @ajsutton for an approval on adding awaitility
dependency.
Cool, I used it to get the |
...egration-test/java/tech/pegasys/teku/ethereum/executionclient/rest/OkHttpRestClientTest.java
Outdated
Show resolved
Hide resolved
infrastructure/async/src/testFixtures/java/tech/pegasys/teku/infrastructure/async/Waiter.java
Show resolved
Hide resolved
469caf2
to
bb17887
Compare
PR Description
All exceptions are currently handled in the OkHttp callback
onFailure
method.This PR makes sure no unchecked exception (different from expected IOException) is thrown in
RequestBody.writeTo
method. If such is thrown, then an exception will be thrown in a background thread, which will triggerTekuDefaultExceptionHandler
to print a scary log message.Fixed Issue(s)
fixes #6109
Documentation
doc-change-required
label to this PR if updates are required.Changelog