Builder circuit breaker #6083
Merged
Builder circuit breaker #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Aug 17, 2022
...tor/src/main/java/tech/pegasys/teku/validator/coordinator/BlockOperationSelectorFactory.java
Outdated
Show resolved
Hide resolved
|
Looks really good overall |
tbenr
force-pushed
the
builder_circuit_breaker
branch
2 times, most recently
from
496d45e to
8ba53d2
Compare
tbenr
force-pushed
the
builder_circuit_breaker
branch
2 times, most recently
from
8056376 to
ab00718
Compare
tbenr
commented
Aug 22, 2022
dedicated BuilderCircuitBreaker for better modularity\testing
implemented tests
move to chain builder to prepare the state pass BuilderCircuitBreaker to Stub too
tbenr
force-pushed
the
builder_circuit_breaker
branch
from
77009fc to
7071dc0
Compare
rolfyone
reviewed
Aug 23, 2022
...layer/src/main/java/tech/pegasys/teku/ethereum/executionlayer/ExecutionLayerManagerStub.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces
BuilderCircuitBreakerinterface and implementationmoves all the fallback check responsibility into
ExecutionLayerManagerImpl(entirely removed fromBlockOperationSelectorFactory)We have three new params:
--Xbuilder-circuit-breaker-enabled-> defaulttrue--Xbuilder-circuit-breaker-window-> default32--Xbuilder-circuit-breaker-allowed-faults-> default8fixes #6058
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog