Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and/or move builder specific classes #6082

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Rename and/or move builder specific classes #6082

merged 2 commits into from
Aug 17, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Aug 16, 2022 •
edited
Loading

PR Description

  • Remove execution prefix from builder classes
  • Move schema classes from execution to builder package

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to run spotless.

@StefanBratanov StefanBratanov enabled auto-merge (squash) August 17, 2022 08:07
@StefanBratanov StefanBratanov merged commit fff8886 into Consensys:master Aug 17, 2022
@come-maiz come-maiz mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @ajsutton