Migrate hot blocks if using blinded storage #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a starting point for blinded storage migration - migrate blinded blocks so that we can start up if we were previously using full hot block storage - migrate the first block (lowest slot) from finalized storage - this will ensure back filling happens from the right spot. A future PR will cater for migrating finalized storage and non canonical block storage. Partially addresses Consensys#5312 Signed-off-by: Paul Harris <[email protected]>
rolfyone
commented
Jul 17, 2022
storage/src/main/java/tech/pegasys/teku/storage/server/Database.java
Outdated
Show resolved
Hide resolved
rolfyone
commented
Jul 17, 2022
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/BlindedHotBlockMigration.java
Outdated
Show resolved
Hide resolved
…gration to guard it against multiple execution - renamed several new functions to try to make them more consistent. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
rolfyone
commented
Jul 18, 2022
teku/src/main/java/tech/pegasys/teku/cli/subcommand/debug/DebugDbCommand.java
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
ajsutton
approved these changes
Jul 18, 2022
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/BlindedHotBlockMigration.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/BlindedHotBlockMigration.java
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a starting point for blinded storage migration
migrate blinded blocks so that we can start up if we were previously using full hot block storage
migrate the first block (lowest slot) from finalized storage - this will ensure back filling happens from the right spot.
A future PR will cater for migrating finalized storage and non canonical block storage.
Blinded block storage is still off by default, so this migration is only performed if the feature toggle is on. It's worth noting that once you've enabled that toggle, you won't be able to go back to using the old storage, as your hotblock storage will have moved and teku won't start without hotblocks to build the protoarray.
Partially addresses #5312
Signed-off-by: Paul Harris [email protected]
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog