Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder fallback improvements #5935

Merged
merged 4 commits into from
Jul 15, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Jul 14, 2022

Three new fallback reasons added

NOT_NEEDED: when builder is not configured and validator is not registered, which covers the configuration in which blinded flow is active but builder endpoint and validator registration are not configured. The fallback log in this case is at DEBUG level

TRANSITION_NOT_FINALIZED: substitute FORCED

BUILDER_NOT_CONFIGURED: indicates that the validator was registered but no builder endpoint was configured.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tbenr tbenr enabled auto-merge (squash) July 15, 2022 06:03
@tbenr tbenr merged commit fb879b4 into Consensys:master Jul 15, 2022
@tbenr tbenr deleted the fallback_reason_improvements branch July 15, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants