Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEV Boost\Builder] Send Validator Registrations in Batches #5829

Merged
merged 11 commits into from
Jun 22, 2022
Merged

[MEV Boost\Builder] Send Validator Registrations in Batches #5829

merged 11 commits into from
Jun 22, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jun 22, 2022 •
edited
Loading

PR Description

  • Added ValidatorRegistrationBatchSender to send registrations in batches
  • Added a check in ValidatorRegistrator on beginning of epoch to make sure there is no registration still running for another epoch.
  • Initialised the ValidatorRegistrationBatchSender in ValidatorClientService
  • Add hidden CLI option for the batch size

Fixed Issue(s)

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr
tbenr approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nit

tbenr
tbenr approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) June 22, 2022 14:16
@StefanBratanov StefanBratanov merged commit d35d858 into Consensys:master Jun 22, 2022
@StefanBratanov StefanBratanov deleted the validator_registration_batches branch June 22, 2022 17:13
@come-maiz come-maiz mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @tbenr