-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MEV Boost\Builder] Add Builder Specific Metrics #5777
[MEV Boost\Builder] Add Builder Specific Metrics #5777
Conversation
...pegasys/teku/ethereum/executionclient/metrics/MetricRecordingExecutionBuilderClientTest.java
Fixed
Show fixed
Hide fixed
...pegasys/teku/ethereum/executionclient/metrics/MetricRecordingExecutionBuilderClientTest.java
Fixed
Show fixed
Hide fixed
...pegasys/teku/ethereum/executionclient/metrics/MetricRecordingExecutionBuilderClientTest.java
Fixed
Show fixed
Hide fixed
...pegasys/teku/ethereum/executionclient/metrics/MetricRecordingExecutionBuilderClientTest.java
Fixed
Show fixed
Hide fixed
...cture/metrics/src/test/java/tech/pegasys/teku/infrastructure/metrics/RequestCounterTest.java
Fixed
Show resolved
Hide resolved
LGTM generally. But it would be interesting to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
84b1e08
to
2ff65bb
Compare
PR Description
MetricRecordingExecutionBuilderClient
similar toMetricRecordingValidatorApiChannel
MetricsCountersByIntervals
to track requests by method name, outcome and execution time intervalexecutionPayloadSourceCounter
inExecutionLayerChannelImpl
to track where the execution payload is coming from (local_el, builder, builder_local_el_fallback)final
here and there toExecutionLayerManagerImplTest
Metrics look like this
Fixed Issue(s)
related to #5711
Documentation
doc-change-required
label to this PR if updates are required.Changelog