Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEV Boost\Builder] Add Builder Specific Metrics #5777

Merged
merged 10 commits into from
Jun 16, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jun 13, 2022

PR Description

  • Added a MetricRecordingExecutionBuilderClient similar to MetricRecordingValidatorApiChannel
  • Used MetricsCountersByIntervals to track requests by method name, outcome and execution time interval
  • Added executionPayloadSourceCounter in ExecutionLayerChannelImpl to track where the execution payload is coming from (local_el, builder, builder_local_el_fallback)
  • Added some final here and there to ExecutionLayerManagerImplTest

Metrics look like this

# HELP beacon_builder_requests_total Counter recording the number of requests made to the builder by method, outcome and execution time interval
# TYPE beacon_builder_requests_total counter
beacon_builder_requests_total{method="get_header",outcome="SUCCESS",interval="[0,100)",} 7.0
beacon_builder_requests_total{method="get_payload",outcome="SUCCESS",interval="[0,100)",} 8.0
beacon_builder_requests_total{method="register_validators",outcome="SUCCESS",interval="[0,100)",} 1.0
beacon_builder_requests_total{method="status",outcome="SUCCESS",interval="[0,100)",} 10.0

Fixed Issue(s)

related to #5711

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor

tbenr commented Jun 14, 2022

LGTM generally. But it would be interesting to use MetricsCountersByIntervals and we could start tracking response times on API. BN as well as engine\builder

@StefanBratanov StefanBratanov marked this pull request as ready for review June 15, 2022 12:50
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) June 16, 2022 15:20
@StefanBratanov StefanBratanov merged commit 25d4b65 into Consensys:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants