Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEV Boost\Builder] extends proposer config with validator registration info #5649

Merged

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 31, 2022

introduces validator_registration object in Config under ProposerConfig
removes Optional from defaultConfig (it is mandatory)

validator_registration object is optional,
inside validator_registration:

  • enabled is mandatory
  • gasLimit is optional (meant to be defaulted to 30_000_000 by teku internally)

in the default_config, you can use validator_registration to apply a default config to all keys, and then apply an override to a single one if needed.

when validator_registration is not specified, it is considered disabled.

fixes #5640

example 1:

{
  "proposer_config": {
    "0xa057816155ad77931185101128655c0191bd0214c201ca48ed887f6c4c6adf334070efcd75140eada5ac83a92506dd7a": {
      "fee_recipient": "0x50155530FCE8a85ec7055A5F8b2bE214B3DaeFd3",
      "validator_registration": {
        "enabled": true
      }
    }
  },
  "default_config": {
    "fee_recipient": "0x6e35733c5af9B61374A128e6F85f553aF09ff89A"
  }
}

example 2:

{
  "proposer_config": {
    "0xa057816155ad77931185101128655c0191bd0214c201ca48ed887f6c4c6adf334070efcd75140eada5ac83a92506dd7a": {
      "fee_recipient": "0x50155530FCE8a85ec7055A5F8b2bE214B3DaeFd3",
      "validator_registration": {
        "enabled": false
      }
    }
  },
  "default_config": {
    "fee_recipient": "0x6e35733c5af9B61374A128e6F85f553aF09ff89A",
      "validator_registration": {
        "enabled": true,
        "gas_limit": "12345654321"
      }
  }
}

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr marked this pull request as ready for review June 1, 2022 08:26
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 894fd93 into Consensys:master Jun 1, 2022
@tbenr tbenr deleted the proposer_config_with_validators_registration branch June 1, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update proposer_config json with validator registration info
2 participants