Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEV Boost\Builder] Validate SignedBuilderBid #5612

Merged
merged 6 commits into from
May 30, 2022
Merged

[MEV Boost\Builder] Validate SignedBuilderBid #5612

merged 6 commits into from
May 30, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 27, 2022 •
edited
Loading

Implements the BuilderBid validation

  • Introduces: BuilderBidValidator and BuilderBidValidationException

  • validates Bid signature

  • validates the payload header reusing execution payload validations from BlockProcessorBellatrix:

    • moving the validation from processExecutionPayload into a dedicated validateExecutionPayload
    • leave only the state update in processExecutionPayload.

  • validates gasLimit

fixes #5610

related to #5613

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 3ae4145 into Consensys:master May 30, 2022
@tbenr tbenr deleted the validate_builder_bid branch May 30, 2022 13:19
@tbenr tbenr mentioned this pull request Jun 3, 2022
Merged
2 tasks
@come-maiz come-maiz mentioned this pull request Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement BuilderBid validations
2 participants
@tbenr @StefanBratanov