Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEV Boost\Builder] Add a builder rest api client #5521

Merged
merged 11 commits into from
May 17, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 17, 2022

PR Description

Implement the builder rest api per the spec https://ethereum.github.io/builder-specs/

Changes:

  • Implemented RestExecutionBuilderClient (previously they were throwing unsupported operation exception)
  • Deleted old schema objects and serialization classes, which were used for the builder web3j implementation
  • Use a schemaDefinitionCache to access the json type definitions in the rest api client
  • Added BuilderApiResponse class to wrap the json responses coming from the rest api
  • Changed the BuilderExecutionClient to use the spec classes rather than internal ones
  • Modified Web3JExecutionBuilderClient to throw deprecated exception and deleted its test (it will be removed fully in the upcoming PRs)

Fixed Issue(s)

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title [MEV Boost\Builder] Implement builder rest api client [MEV Boost\Builder] Add a builder rest api client May 17, 2022
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 005b1e5 into Consensys:master May 17, 2022
@StefanBratanov StefanBratanov deleted the builder_rest_api branch May 17, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants