Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move execution client logic to a separate module #5438

Merged
merged 3 commits into from
May 9, 2022
Merged

Move execution client logic to a separate module #5438

merged 3 commits into from
May 9, 2022

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 5, 2022 •
edited
Loading

PR Description

  • Rename ethereum:executionengine to ethereum:executionclient
  • Move client package from ethereum:executionlayer to ethereum:executionclient
  • Changed json compare assertions for Web3JExecutionBuilderClientTest in order to work for both Windows/Mac OS
  • Rename ExecutionClientProvider to ExecutionWeb3jClientProvider

Fixed Issue(s)

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title Rename move ethereum module Rename executionengine to executionclient in ethereum module May 5, 2022
@StefanBratanov StefanBratanov changed the title Rename executionengine to executionclient in ethereum module Move execution client logic to a separate module May 5, 2022
@StefanBratanov StefanBratanov marked this pull request as ready for review May 5, 2022 17:34
@StefanBratanov StefanBratanov force-pushed the rename_move_ethereum_module branch 2 times, most recently from 3258155 to a7dd162 Compare May 8, 2022 03:16
ajsutton
ajsutton approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@StefanBratanov StefanBratanov enabled auto-merge (squash) May 9, 2022 02:37
@StefanBratanov StefanBratanov force-pushed the rename_move_ethereum_module branch from a7dd162 to 7c74521 Compare May 9, 2022 02:37
@StefanBratanov StefanBratanov merged commit 109458a into Consensys:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @ajsutton