Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEV-Boost\builder] implement execution builder api client #5406

Merged
merged 5 commits into from
May 3, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 2, 2022

PR Description

  • Introduces Web3JExecutionBuilderClient
  • Introduces all the required execution client schema files to support the new apis
  • Introduced required SSZ objects (SignedValidatorRegistrationV1 and SignedBuilderBidV1) to be able to handle the signature (generation\validation).

In upcoming PR I'll remove builder API from Web3JExecutionEngineClient and integrate Web3JExecutionBuilderClient in ExecutionEngineChannel

Fixed Issue(s)

related to #5396

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth talking through the details of this on the call tonight - I think it generally looks right, but I am quite confused why the execution builder is returning beacon block content like slashings etc. The execution layer ideally wouldn't know anything about those and that's where most of the API trouble is coming from. But I'm not familiar with the latest builder api specs so am probably missing something.

And I think there's a strong argument here that we should be able to have a version of these APIs that does just send SSZ instead of JSON - particularly if the whole beacon block winds up needing to be sent.

@tbenr tbenr force-pushed the update_builder_client branch from 2b86456 to b1f1153 Compare May 3, 2022 05:12
@tbenr tbenr enabled auto-merge (squash) May 3, 2022 09:52
@tbenr tbenr merged commit 7425e0b into Consensys:master May 3, 2022
@tbenr tbenr deleted the update_builder_client branch May 3, 2022 09:54
@lightclient
Copy link

I am quite confused why the execution builder is returning beacon block content like slashings etc. The execution layer ideally wouldn't know anything about those and that's where most of the API trouble is coming from.

@ajsutton the builder is accepting beacon block content, not returning it. They need the signed blinded beacon block to verify the proposer's signature and to be able to release it the network in case the proposer tries to withhold. If they only received the blinded beacon block header, they wouldn't have enough information to propagate the block on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants