[MEV boost] improve blinded block validator options and flow handling #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Apr 13, 2022
teku/src/main/java/tech/pegasys/teku/cli/options/ValidatorProposerOptions.java
Show resolved
Hide resolved
validator/api/src/main/java/tech/pegasys/teku/validator/api/ValidatorConfig.java
Outdated
Show resolved
Hide resolved
| @@ -82,7 +85,7 @@ private SafeFuture<DutyResult> sendBlock(final SignedBeaconBlock signedBlock) { | |||
|
|
|||
| public SafeFuture<Optional<BeaconBlock>> createUnsignedBlock(final BLSSignature randaoReveal) { | |||
| return validatorApiChannel.createUnsignedBlock( | |||
| slot, randaoReveal, validator.getGraffiti(), false); | |||
| slot, randaoReveal, validator.getGraffiti(), useBlindedBlock); | |||
There was a problem hiding this comment.
This definitely makes more sense - nice clean up.
tbenr
force-pushed
the
improve_vc_blinded_block_handling
branch
from
059c9de to
bf01053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I renamed
--Xvalidators-blinded-blocks-api-enabledto--Xvalidators-proposer-blinded-blocks-enabledand moved inValidatorProposerOptionsThe flag now is used in
BlockDutyFactoryandBlockProductionDuty, no more in theOkHttpValidatorRestApiClientwhich now choose the right endpoint based on blinded flag at runtime.Enabling
--Xvalidators-proposer-mev-boost-enabledautomatically enables--Xvalidators-proposer-blinded-blocks-enabledAdd a signer test for blinded block
Fixed Issue(s)
fixes #5260
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog