[MEV Boost] Allow Blinded block creation flow in BN - Part1 #5249
Conversation
| .getPayload(payloadId, blockSlotState.getSlot()) | ||
| .join())); | ||
|
|
||
| if (isMevBoostEnabled || blinded) { |
There was a problem hiding this comment.
It feels weird to me that you could ask for a non-blinded block but be given one anyway because mev boost is enabled. Nots are it's wrong as such, just feels very unexpected. Maybe it's just that blinded should be forceBlinded?
There was a problem hiding this comment.
Thinking again this is wrong.
At high-level these are the conditions I want to handle.
if (isMevBoostEnabled && blinded) {
// blinded mevboost flow
// set `bodyBuilder.executionPayloadHeader` via `executionEngineChannel.getPayloadHeader`
} else if (!isMevBoostEnabled && blinded) {
// blinded non-mevboost flow (To Be implemented - issue #5103)
// set `bodyBuilder.executionPayloadHeader` via `executionEngineChannel.getPayload` (extract header from full payload)
// cache the full payload to be used to "unblind" the signed block before publication
} else {
// non-blind standard flow
// set `bodyBuilder.executionPayload` via `executionEngineChannel.getPayload`
}There was a problem hiding this comment.
ah yeah that makes sense to me.
...tor/src/main/java/tech/pegasys/teku/validator/coordinator/BlockOperationSelectorFactory.java
Outdated
Show resolved
Hide resolved
| @@ -115,7 +119,8 @@ private ExecutionPayload getExecutionPayload(final BeaconBlock block) { | |||
| return BeaconBlockBodyBellatrix.required(block.getBody()).getExecutionPayload(); | |||
| } | |||
|
|
|||
| private BeaconBlock assertBlockCreated(final int blockSlot, final Spec spec) | |||
| private BeaconBlock assertBlockCreated( | |||
There was a problem hiding this comment.
We probably should add a test for the cases where isMevBoostEnabled and blinded are true (and the various combinations). Looks like we're always passing false, false at the moment.
There was a problem hiding this comment.
quite not there yet. I'll do a Part-2 of the PR.
...src/test/java/tech/pegasys/teku/validator/coordinator/BlockOperationSelectorFactoryTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/tech/pegasys/teku/validator/remote/apiclient/OkHttpValidatorRestApiClient.java
Show resolved
Hide resolved
tbenr
changed the title
…r can behave based on builder itself
tbenr
force-pushed
the
blindedblock_flow
branch
from
093a039 to
6b53bc7
Compare
PR Description
BlockFactorybecome mev_boost \ blinded block awareBlockOperationSelectorFactorybecome mev_boost aware.Instead of haveing a dedicated
BlindedBeaconBlockBodyBuilder, the flow has been integrated inBeaconBlockBodyBuilderBellatrix.BeaconBlockBodyBuilderinterface exposesisBlindedand will be used to expose toBlockOperationSelectorFactoryto generate a builderConsumer that can reason about blinded\non-blinded blocks.Fixed Issue(s)
#5261
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog