V0.10.1 #1100
Merged
V0.10.1 #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Jan 22, 2020
util/src/main/java/tech/pegasys/artemis/util/bls/BLSKeyPair.java
Outdated
Show resolved
Hide resolved
| BLS_WITHDRAWAL_PREFIX = Bytes.wrap(new byte[1]); | ||
|
|
||
| // Time parameters | ||
| MIN_GENESIS_DELAY = 300; |
benjaminion
force-pushed
the
v0.10.0
branch
3 times, most recently
from
26f1fe0 to
e205178
Compare
In preparation for spec 0.10.0. WIP - temporarily breaks many things.
Unfortunately, there remains a bug in the fastAggregateVerify reference test data, so those will fail until the test suite is fixed.
# Conflicts: # ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
# Conflicts: # ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java # ethereum/statetransition/src/test-support/java/tech/pegasys/artemis/statetransition/BeaconChainUtil.java # validator/client/src/main/java/tech/pegasys/artemis/validator/client/ValidatorClient.java
# Conflicts: # ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/blocks/BeaconBlockHeader.java # ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/state/Fork.java
ajsutton
reviewed
Mar 11, 2020
There was a problem hiding this comment.
Looks good. Hopefully the comments around storing the checkpoint states will make that area clearer, and I suspect we should split the code to publish as soon as the node slot block is imported into a separate PR and make sure we have a nice clean way to do that.
.../statetransition/src/main/java/tech/pegasys/artemis/statetransition/util/ForkChoiceUtil.java
Outdated
Show resolved
Hide resolved
.../statetransition/src/main/java/tech/pegasys/artemis/statetransition/util/ForkChoiceUtil.java
Outdated
Show resolved
Hide resolved
.../statetransition/src/main/java/tech/pegasys/artemis/statetransition/util/ForkChoiceUtil.java
Outdated
Show resolved
Hide resolved
.../statetransition/src/main/java/tech/pegasys/artemis/statetransition/util/ForkChoiceUtil.java
Outdated
Show resolved
Hide resolved
...aconchain/src/main/java/tech/pegasys/artemis/services/beaconchain/BeaconChainController.java
Outdated
Show resolved
Hide resolved
...ordinator/src/main/java/tech/pegasys/artemis/validator/coordinator/ValidatorCoordinator.java
Outdated
Show resolved
Hide resolved
...ordinator/src/main/java/tech/pegasys/artemis/validator/coordinator/ValidatorCoordinator.java
Outdated
Show resolved
Hide resolved
…-v0.10.0 # Conflicts: # artemis/src/main/java/tech/pegasys/artemis/DepositCommand.java # data/beaconrestapi/src/main/java/tech/pegasys/artemis/beaconrestapi/beaconhandlers/BeaconChainHeadHandler.java # data/beaconrestapi/src/test/java/tech/pegasys/artemis/beaconrestapi/beaconhandlers/BeaconChainHeadHandlerTest.java
…-v0.10.0 # Conflicts: # services/beaconchain/src/main/java/tech/pegasys/artemis/services/beaconchain/BeaconChainController.java
cemozerr
reviewed
Mar 16, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings us up to the v0.10.0 core beacon chain spec. It includes a big BLS refactor to make the interfaces more uniform with the BLS signature standard.
Note: does not include other v0.10.0/1 changes, such as fork choice
Waiting for a couple of external things before we can merge
Also
We probably want to stay at 0.9.4 until a number of other clients are ready with 0.10.0