Skip to content

Commit

Permalink
chore: File watcher cherry pick (#416)
Browse files Browse the repository at this point in the history
  • Loading branch information
darioAnongba authored Nov 10, 2021
1 parent d5b1192 commit 88b1778
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Quorum Key Manager Release Notes

## v21.9.3 (2021-11-10)

### 🛠 Bug fixes
* Fixes bug in Hashicorp client that prevents the process from exiting when a new token is written or updated from filesystem.

## v21.9.2 (2021-10-18)

### 🛠 Bug fixes
Expand Down
6 changes: 3 additions & 3 deletions src/infra/hashicorp/token/file-watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,16 @@ func (rtl *RenewTokenWatcher) Start(ctx context.Context) error {
}

if event.Op&fsnotify.Write == fsnotify.Write {
rtl.logger.With("event_name", event.Name).Debug("file has been updated")
rtl.logger.Debug("token file has been updated")
if err := rtl.refreshToken(); err != nil {
return err
}
} else if event.Op&fsnotify.Create == fsnotify.Create {
rtl.logger.With("event_name", event.Name).Debug("file has been created")
rtl.logger.Debug("token file has been created")
if err := rtl.refreshToken(); err != nil {
return err
}
}
rtl.logger.Debug("event:", event)
case err, ok := <-rtl.watcher.Errors:
if !ok {
return nil
Expand Down Expand Up @@ -129,6 +128,7 @@ func (rtl *RenewTokenWatcher) refreshToken() error {
}

rtl.client.SetToken(token)

// Immediately delete the file after it was read
err = os.Remove(rtl.tokenPath)
if err != nil {
Expand Down

0 comments on commit 88b1778

Please sign in to comment.