Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to match new changes in GoQuorum with Geth v1.9.19 #83

Merged
merged 5 commits into from
Mar 10, 2021

Conversation

ricardolyn
Copy link
Contributor

@ricardolyn ricardolyn commented Mar 8, 2021

Note: this PR will have to be merged with a RED pipeline as the necessary changes on GraphQL arguments are not yet merged in GoQuorum repo. Tests with basic tags will be the ones failing in the GraphQL step

Changes

  • Remove graphql arguments for port, etc; as now they are the same as the rpc/http arguments (it runs in the same port/host).
  • Fix issue with deleting data directory. The problem is that the datadir is deleted while get is still running and only after it, the service is shutdown. However, a new change of 1.9.19 does a cache file of the freeze db while stopping the blockchain service, which then creates the folder again. The solution is to check if genesis.json file is there instead of the folder itself (as it might be the folder with this cached db).
  • Add improvements on Istanbul validator management test to remove flakiness in some runs when block is not right.
  • Fixed graphql tests as they had the wrong tags and then not running as part of ATs. Moved to be a basic test as is not doing anything advanced.

The approach datadir deleting should be reviewed in the future to only be done after the geth process stops

References

@ricardolyn ricardolyn self-assigned this Mar 8, 2021
@ricardolyn ricardolyn marked this pull request as ready for review March 8, 2021 13:02
@ricardolyn ricardolyn changed the title [Upgrade] Update AT to match new changes in GoQuorum with Get v1.9.19 Update tests to match new changes in GoQuorum with Get v1.9.19 Mar 8, 2021
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn changed the title Update tests to match new changes in GoQuorum with Get v1.9.19 Update tests to match new changes in GoQuorum with Geth v1.9.19 Mar 9, 2021
Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSGTM

@ricardolyn ricardolyn merged commit a955284 into Consensys:master Mar 10, 2021
@ricardolyn ricardolyn deleted the upgrade/geth-1.9.19 branch March 10, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants