This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Support quorum 2.6.0. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
libby
commented
May 6, 2020
libby
commented
- generate genesis.json to work for 2.6.0.
- add --allow-insecure-unlock flag to geth startup params.
* generate genesis.json to work for 2.6.0. * add --allow-insecure-unlock flag to geth startup param.
jbhurat
reviewed
May 6, 2020
| @@ -238,6 +238,9 @@ spec: | |||
| <%- elsif @config["quorum"]["consensus"] == "istanbul" -%> | |||
| args=\" --gcmode archive --istanbul.blockperiod 3 --syncmode full --mine --minerthreads 1 \"; | |||
| RPC_APIS=\"$RPC_APIS,istanbul\"; | |||
| <%- end -%> | |||
| <%- if @config["quorum"]["quorum"]["Quorum_Version"] == "2.6.0" -%> | |||
There was a problem hiding this comment.
Is it possible to make this check as >= 2.6.0
There was a problem hiding this comment.
Was debating that, but thought that we would have to explicitly support and check other issues when a new version became available. But I'll add it, as it will allow support for fixes and minor version changes.
templates/quorum/genesis.json.erb
Outdated
| "eip150block": 0, | ||
| "eip150hash": "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "eip155block": 0, | ||
| "eip158block": 0, | ||
| <%-# for 2.6 maxCodeSize config has changed. -%> | ||
| <%- if @config["quorum"]["quorum"]["Quorum_Version"] == "2.6.0" -%> |
There was a problem hiding this comment.
Is it possible to make this check >= 2.6.0
templates/quorum/genesis.json.erb
Outdated
| @@ -103,7 +118,18 @@ end | |||
| "epoch": 30000, | |||
| "policy": 0 | |||
| }, | |||
| <%-# for 2.6 maxCodeSize config has changed. -%> | |||
| <%- if @config["quorum"]["quorum"]["Quorum_Version"] == "2.6.0" -%> | |||
There was a problem hiding this comment.
Is it possible to make this check >= 2.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.