This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Refactor quorum-init script #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separates quorum-init into 2 scripts...
-quorum-init only generates resources needed for quorum
-qube-init calls quorum-init and generates kubernetes resources
updates calls to quorum-init in readme/tests
adds action flag (--action create|update, --action=create|update, -acreate|update) to skip user prompt of asking about out directory, not having flag will run prompt if out directory exists
example of how to run with flags:
./quorum-init --action=create qubernetes.yaml
./quorum-init --action=update qubernetes.yaml
./qube-init --action=create qubernetes.yaml
./qube-init --action=update qubernetes.yaml