This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
[qctl] support external nodes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add external_nodes to configyaml used by qctl. * add support for listing the external nodes in a network: qctl ls extnodes --all
qctl add extnode --enode=enode://[email protected]:7000 --tmurl=http://1.2.3.4:9000 --nodekeyaddr="0x1234334" * TODO: find a way to preserve double quotes in gopkg.in/yaml.v2, or use another yaml parsing library, need to preserve quotes for hex nodekey address in qubernetes config, or else the hex number is evaluated. currently wrapping in single quotes (ugly), as this is preserved, e.g. '"0x92392CAF837B94BC8541D0baE2db41BE2B999F39"'.
* support deleting external nodes: qctl delete external-node * allow external node Node_Acct_Addr to be set as a hex without quotes or a string hex in the qubernetes yaml. cover both cases in istanbul-validator.toml.erb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. add, delete, ls
Node_Acct_Addrfield to be set to a hex without quotesor a string hex in the qubernetes yaml. If it is set as a hex without quotes, the hex value will
be converted to a BigNum, cover both cases in
istanbul-validator.toml.erb.the yaml parser (https://godoc.org/gopkg.in/yaml.v2) used does not preserve double
quotes around the hex In place write strips out comments mikefarah/yq#19