Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: Beta v1.3 #703

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Prover: Beta v1.3 #703

merged 3 commits into from
Feb 18, 2025

Conversation

gusiri
Copy link
Contributor

@gusiri gusiri commented Feb 18, 2025

This PR

  • bump constraints to beta-v1.3-rc3
  • update trace limits
  • use go-corset to generate zkevm.bin

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

DavePearce and others added 2 commits February 18, 2025 06:32
This updates the prover / checker to use the latest version of
`go-corset`.
Copy link

cla-assistant bot commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 18, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gusiri
❌ DavePearce
You have signed the CLA already but the status is still pending? Let us recheck it.

@gusiri gusiri had a problem deploying to docker-build-and-e2e February 18, 2025 06:34 — with GitHub Actions Error
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (a72a7e9) to head (958e7fa).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #703   +/-   ##
=========================================
  Coverage     68.38%   68.38%           
  Complexity     1185     1185           
=========================================
  Files           323      323           
  Lines         13131    13131           
  Branches       1319     1319           
=========================================
  Hits           8979     8979           
  Misses         3600     3600           
  Partials        552      552           
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø)
kotlin 66.03% <ø> (ø) Carriedforward from 08ea4c9

*This pull request uses carry forward flags. Click here to find out more.

@gusiri gusiri temporarily deployed to docker-build-and-e2e February 18, 2025 08:45 — with GitHub Actions Inactive
@srinathln7 srinathln7 self-requested a review February 18, 2025 10:36
@gusiri gusiri had a problem deploying to docker-build-and-e2e February 18, 2025 11:59 — with GitHub Actions Error
@gusiri gusiri force-pushed the prover/beta-v1.3-rc3 branch from 4c25f53 to 08ea4c9 Compare February 18, 2025 12:51
@gusiri gusiri temporarily deployed to docker-build-and-e2e February 18, 2025 12:52 — with GitHub Actions Inactive
@gusiri gusiri marked this pull request as ready for review February 18, 2025 13:19
@gusiri gusiri temporarily deployed to docker-build-and-e2e February 18, 2025 13:22 — with GitHub Actions Inactive
@gusiri gusiri merged commit 2c8a163 into main Feb 18, 2025
25 checks passed
@gusiri gusiri deleted the prover/beta-v1.3-rc3 branch February 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants