Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use already-built image in Dockerfile of l1-node-genesis-generator #669

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Feb 10, 2025

This PR implements issue(s) #638

  • use external docker image ethpandaops/ethereum-genesis-generator in Dockerfile of l1-node-genesis-generator
  • get genesis time automatically in the docker container and make L1_GENESIS_TIME optional in the docker compose file

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho self-assigned this Feb 10, 2025
@jonesho jonesho marked this pull request as draft February 10, 2025 16:02
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 10, 2025 16:02 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (0eb6eb4) to head (57bceba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #669      +/-   ##
============================================
- Coverage     68.43%   68.38%   -0.06%     
  Complexity     1185     1185              
============================================
  Files           323      323              
  Lines         13130    13131       +1     
  Branches       1318     1319       +1     
============================================
- Hits           8986     8979       -7     
- Misses         3593     3600       +7     
- Partials        551      552       +1     
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø) Carriedforward from 18a7faf
kotlin 66.03% <ø> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@jonesho jonesho temporarily deployed to docker-build-and-e2e February 11, 2025 06:16 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 11, 2025 06:38 — with GitHub Actions Inactive
@jonesho jonesho marked this pull request as ready for review February 11, 2025 06:40
@jonesho jonesho requested a review from VGau February 11, 2025 10:54
@jonesho jonesho force-pushed the 638-genesis-generator-use-already-built-docker-image branch from 02251e8 to 18a7faf Compare February 12, 2025 08:34
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 12, 2025 08:34 — with GitHub Actions Inactive
@jonesho jonesho requested review from VGau and removed request for VGau February 12, 2025 08:34
VGau
VGau previously approved these changes Feb 12, 2025
@jonesho jonesho requested a review from jpnovais February 12, 2025 15:53
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 13, 2025 14:31 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the 638-genesis-generator-use-already-built-docker-image branch from 04f9244 to 57bceba Compare February 13, 2025 18:39
@jonesho jonesho requested a review from VGau February 13, 2025 18:39
@jonesho jonesho temporarily deployed to docker-build-and-e2e February 13, 2025 18:39 — with GitHub Actions Inactive
@jonesho jonesho merged commit c7f6e59 into main Feb 13, 2025
22 checks passed
@jonesho jonesho deleted the 638-genesis-generator-use-already-built-docker-image branch February 13, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants