bugfix(contracts): Incorrect Expiration Check & Subject Handling in balanceOf #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
satyajeetkolhapure,
orbmis,
arthur-remy and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #891 +/- ##
===========================================
+ Coverage 48.59% 75.69% +27.10%
===========================================
Files 18 40 +22
Lines 391 934 +543
Branches 63 165 +102
===========================================
+ Hits 190 707 +517
- Misses 198 224 +26
Partials 3 3 ☔ View full report in Codecov by Sentry. |
arthur-remy
approved these changes
Feb 3, 2025
alainncls
force-pushed
the
fix/incorrect-expiration-check-and-subject-handling-in-balanceof
branch
from
1df3a0f to
85d03b9
Compare
alainncls
deleted the
fix/incorrect-expiration-check-and-subject-handling-in-balanceof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related ticket
Fixes #890
Type of change
Check list