Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Remove updateRouter Methods to Prevent Inconsistencies #883

Merged

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Related ticket

Fixes #882

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Jan 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (d8af275) to head (c2c4cbc).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
contracts/src/AttestationReader.sol 75.00% 1 Missing ⚠️
contracts/src/AttestationRegistry.sol 75.00% 1 Missing ⚠️
contracts/src/ModuleRegistry.sol 75.00% 1 Missing ⚠️
contracts/src/PortalRegistry.sol 80.00% 1 Missing ⚠️
contracts/src/SchemaRegistry.sol 75.00% 1 Missing ⚠️
contracts/src/stdlib/IndexerModuleV2.sol 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #883       +/-   ##
===========================================
+ Coverage   48.59%   78.70%   +30.11%     
===========================================
  Files          18       49       +31     
  Lines         391     1099      +708     
  Branches       63      186      +123     
===========================================
+ Hits          190      865      +675     
- Misses        198      231       +33     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the chore/remove-updaterouter-methods-to-prevent-inconsistencies branch 2 times, most recently from c25be62 to 8061577 Compare January 30, 2025 14:36
@alainncls alainncls force-pushed the chore/remove-updaterouter-methods-to-prevent-inconsistencies branch from a28e12d to c2c4cbc Compare February 4, 2025 10:18
@alainncls alainncls enabled auto-merge (squash) February 4, 2025 10:18
@alainncls alainncls disabled auto-merge February 4, 2025 10:20
@alainncls alainncls merged commit 7c15db0 into dev Feb 4, 2025
10 checks passed
@alainncls alainncls deleted the chore/remove-updaterouter-methods-to-prevent-inconsistencies branch February 4, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Remove updateRouter Methods to Prevent Inconsistencies
3 participants