feat: specify error for invalid tests #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts in place the mechanism for embedding error messages into the invalid tests themselves. That way, anything which changes what errors are reported results in a failing test.
This puts through a few more fixes for the error checking mechanism, and adds errors for basic and constant tests. There's a fair way to go yet though.
DavePearce
force-pushed
the
399-specify-error-for-invalid-tests
branch
from
fb10621 to
c66e8e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a requirement that all invalid tests (i.e. tests which should fail with an error) have the exact error specified as part of the test. A new comment syntax is supported for this purpose.