Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-exposed frontend.CompiledConstraintSystem #217

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Dec 22, 2021

Introduced by #200 -->
frontend.CompiledConstraintSystem became compiled.ConstraintSystem, but compiled is internal/ .

Note that GetCounters() []compiled.Counter in the interface returns something from internal which may be impractical / need revisit.

@gbotrel gbotrel requested a review from ivokub December 22, 2021 22:39
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree that it is not great that GetCounters() returns something from internal, but we can revisit it later.

@gbotrel gbotrel merged commit 0c2d931 into develop Dec 22, 2021
@gbotrel gbotrel deleted the fix-internal-compiled branch December 22, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants