Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/poseidon2 #1300

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Feat/poseidon2 #1300

merged 17 commits into from
Nov 25, 2024

Conversation

ThomasPiellard
Copy link
Collaborator

@ThomasPiellard ThomasPiellard commented Oct 16, 2024

Description

Implementation of poseidon2 for t=2,3 following
reference implementation
reference paper
TBD: algos 1, 2, 3 of https://tosc.iacr.org/index.php/ToSC/article/view/8913/8489 for finding internal matrices when t>3

see gnark-crypto's corresponding PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

see TestPoseidon2, tested against gnark-crypto's implementation

How has this been benchmarked?

scs: 632 constraints for t=3
r1cs: 243 constraints for t=3

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the PR follows Consensys/gnark-crypto#553 (review). Next we need to use poseidon2 in other places (commitment, recursion, signature, gkr...) and do some benchmarks.

README.md Outdated Show resolved Hide resolved
@ThomasPiellard ThomasPiellard merged commit 15328ce into master Nov 25, 2024
5 checks passed
@ThomasPiellard ThomasPiellard deleted the feat/poseidon2 branch November 25, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants