Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the splitting of S in S1+2^bS2 in the EDDSA snark circuit.
-->
The splitting was due to an earlier version of gnark-crypto where S was reduced modulo the number of points of the twisted Edwards instead of the group order of the base point.
A twisted Edwards on Z/rZ has at most N=r+2*sqrt(r)+3 points because there are 2 points of multiplicity 2. The group that is used for eddsa contains at most N/2 points because there is a point of order 2 on the twisted Edwards. Therefore l<r.