This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Updated to handle cmdline logging and default gas #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
approved these changes
Mar 12, 2019
| @@ -52,10 +52,17 @@ public static RawTransaction fromTransactionJson(final JsonObject transaction) { | |||
| if (txnParams.getString("data") != null) { | |||
| dataString = txnParams.getString("data"); | |||
| } | |||
|
|
|||
| // TODO(tmm): This should be configurable, but currently matches Geth. | |||
| String gasValue = "90000"; | |||
There was a problem hiding this comment.
Delegating work to Trent, eh? 🤔 ...sneaky
sambacha
pushed a commit
to freight-trust/ethsigner
that referenced
this pull request
Oct 3, 2020
ADHARA: Fix build dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.