Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document builder endpoint and CLI options. #379

Merged
merged 19 commits into from
Aug 9, 2022

Conversation

rolandtyler
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the Teku documentation standard.

Before creating the PR

Make sure that:

Describe the change

Document the new CLI options and howto/concepts for the Builder endpoint

Issue fixed

Fixes #377

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example lint or vale)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

@rolandtyler rolandtyler requested a review from tbenr July 27, 2022 16:12
@tbenr
Copy link
Contributor

tbenr commented Aug 4, 2022

Hey @StefanBratanov can you have a look here?

docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
docs/Reference/CLI/CLI-Syntax.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Endpoint.md Outdated Show resolved Hide resolved
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolandtyler rolandtyler requested a review from a team August 9, 2022 17:38
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/Concepts/Builder-Network.md Outdated Show resolved Hide resolved
@bgravenorst bgravenorst self-assigned this Aug 9, 2022
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

docs/Concepts/Builder-Network.md Outdated Show resolved Hide resolved
docs/Concepts/Builder-Network.md Outdated Show resolved Hide resolved
docs/Concepts/Builder-Network.md Outdated Show resolved Hide resolved
docs/Concepts/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
docs/HowTo/Builder-Network.md Outdated Show resolved Hide resolved
@bgravenorst bgravenorst merged commit b13777b into Consensys:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhide hidden params for mev-boost\builder
4 participants