generated from Consensys/doc.ethsigner
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about emptyBlockPeriodSeconds #246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 11:46
9e4ecef
to
fb16775
Compare
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 11:53
fb16775
to
64849fc
Compare
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 11:53
64849fc
to
9c96656
Compare
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 11:56
9c96656
to
05c4885
Compare
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 11:58
05c4885
to
6443ea7
Compare
antonydenyer
force-pushed
the
feat/empty-blocks
branch
from
August 2, 2022 12:01
6443ea7
to
2a5a184
Compare
rolandtyler
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits. I also moved the section up so it was just after setting the blockPeriodSeconds
since they're related. LGTM
docs/configure-and-manage/configure/consensus-protocols/qbft.md
Outdated
Show resolved
Hide resolved
docs/configure-and-manage/configure/consensus-protocols/qbft.md
Outdated
Show resolved
Hide resolved
Co-authored-by: baptiste-b-pegasys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Add basic documentation about how to configure empty block period implemented in Consensys/quorum#1433
Impacted parts
For content changes:
For tool changes:
After creating your PR and tests have finished
Make sure that: