Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-qbft-network.md #238

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Update create-qbft-network.md #238

merged 7 commits into from
Jun 21, 2022

Conversation

baptiste-b-pegasys
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Fix arguments on geth launch

Issue fixed

fixes Consensys/quorum#1435

Impacted parts

create QBFT private network

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview June 15, 2022 08:33 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 08:33 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 08:33 Inactive
improve commands to execute
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 09:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 09:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview June 15, 2022 09:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 09:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 09:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:47 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:47 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview June 15, 2022 11:47 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:47 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:47 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview June 15, 2022 11:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 11:57 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 12:55 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 12:55 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview June 15, 2022 12:55 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 12:55 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to no-secret June 15, 2022 12:55 Inactive
@baptiste-b-pegasys
Copy link
Contributor Author

when approved, same modification should be made for IBFT tutorial

@baptiste-b-pegasys baptiste-b-pegasys marked this pull request as ready for review June 16, 2022 06:22
@baptiste-b-pegasys baptiste-b-pegasys requested a review from a team as a code owner June 16, 2022 06:22
@rolandtyler rolandtyler self-assigned this Jun 16, 2022
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 15:12 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 15:12 Inactive
@rolandtyler rolandtyler temporarily deployed to preview June 16, 2022 15:12 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 15:12 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 15:12 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits. Created issue to update IBFT page to match, see #239. LGTM

@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 16:11 Inactive
@rolandtyler rolandtyler temporarily deployed to preview June 16, 2022 16:11 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 16:11 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 16:11 Inactive
@rolandtyler rolandtyler temporarily deployed to no-secret June 16, 2022 16:11 Inactive
@rolandtyler rolandtyler merged commit ea00238 into main Jun 21, 2022
@rolandtyler rolandtyler deleted the baptiste-b-pegasys-patch-2 branch June 21, 2022 19:37
@rolandtyler rolandtyler temporarily deployed to no-secret June 21, 2022 19:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when starting geth
3 participants