Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document updates to QBFT and IBFT configurations #236

Merged

Conversation

rolandtyler
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Updates to QBFT and IBFT configurations:

  • Updated genesis files with ibft and qbft attributes
  • Document smart contract validators
  • document transitions
  • remove deprecated CLI options --istanbul.requesttimeout and --istanbul.blockperiod

Issue fixed

Fixes #218
Fixes #230
Fixes #231

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@rolandtyler rolandtyler requested a review from a team as a code owner June 7, 2022 17:28
@rolandtyler rolandtyler temporarily deployed to preview June 7, 2022 17:28 Inactive
@rolandtyler rolandtyler temporarily deployed to preview June 7, 2022 17:39 Inactive
@rolandtyler rolandtyler temporarily deployed to preview June 7, 2022 17:45 Inactive
Copy link
Contributor

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, otherwise LGTM

docs/reference/genesis.md Outdated Show resolved Hide resolved
…landtyler/doc.goquorum into update-validators-with-smart-contract
@rolandtyler rolandtyler temporarily deployed to preview June 9, 2022 14:28 Inactive
@rolandtyler rolandtyler merged commit 5d7b3af into Consensys:main Jun 9, 2022
@rolandtyler rolandtyler temporarily deployed to no-secret June 9, 2022 14:47 Inactive
@rolandtyler rolandtyler deleted the update-validators-with-smart-contract branch June 9, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants