Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBFT has immediate finality #232

Merged
merged 3 commits into from
May 30, 2022
Merged

IBFT has immediate finality #232

merged 3 commits into from
May 30, 2022

Conversation

siladu
Copy link
Contributor

@siladu siladu commented May 30, 2022 •
edited
Loading

Pull request checklist

https://consensys.github.io/doc.goquorum/PR-232/concepts/consensus/comparing-poa/

Before creating the PR

Make sure that:

Describe the change

Docs incorrectly stated that IBFT does not have immediate finality

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

After creating your PR and tests have finished

Make sure that:

@siladu siladu requested a review from a team as a code owner May 30, 2022 06:45
@siladu siladu temporarily deployed to preview May 30, 2022 06:45 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 06:45 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 06:45 Inactive
@CLAassistant
Copy link

CLAassistant commented May 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

alexandratran
alexandratran approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this mistake! LGTM after minor stylistic suggestions.

docs/concepts/consensus/comparing-poa.md Outdated Show resolved Hide resolved
docs/concepts/consensus/comparing-poa.md Outdated Show resolved Hide resolved
@alexandratran alexandratran mentioned this pull request May 30, 2022
Closed
bgravenorst
bgravenorst approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu temporarily deployed to preview May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to preview May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:03 Inactive
@siladu siladu merged commit 014572c into main May 30, 2022
@siladu siladu deleted the ibft-finality branch May 30, 2022 07:07
@siladu siladu temporarily deployed to no-secret May 30, 2022 07:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgravenorst bgravenorst bgravenorst approved these changes

@alexandratran alexandratran alexandratran approved these changes

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siladu @CLAassistant @macfarla @alexandratran @bgravenorst