Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for unified charts #219

Merged
merged 16 commits into from
May 9, 2022
Merged

updates for unified charts #219

merged 16 commits into from
May 9, 2022

Conversation

joshuafernandes
Copy link
Contributor

@joshuafernandes joshuafernandes commented May 3, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Issue fixed

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@joshuafernandes joshuafernandes requested a review from a team as a code owner May 3, 2022 05:35
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 05:35 Inactive
@joshuafernandes joshuafernandes changed the title updates for unified charts WIP: updates for unified charts May 3, 2022
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 05:47 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 05:49 Inactive
Signed-off-by: Eric Lin <[email protected]>
@Ezzahhh Ezzahhh temporarily deployed to preview May 3, 2022 05:59 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 10:53 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 11:16 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 11:17 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 11:46 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 12:34 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 12:42 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 22:21 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 3, 2022 23:21 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:30 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:35 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:37 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:40 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:43 Inactive
@joshuafernandes joshuafernandes changed the title WIP: updates for unified charts updates for unified charts May 4, 2022
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:51 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 01:52 Inactive
@Ezzahhh Ezzahhh temporarily deployed to preview May 4, 2022 02:04 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 03:01 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 03:03 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 03:57 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview May 4, 2022 04:49 Inactive
@rolandtyler rolandtyler self-assigned this May 5, 2022
@joshuafernandes joshuafernandes temporarily deployed to preview May 5, 2022 23:29 Inactive
@rolandtyler rolandtyler temporarily deployed to preview May 9, 2022 16:33 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some edits. LGTM now.

@joshuafernandes joshuafernandes merged commit 6956f8d into Consensys:main May 9, 2022
@joshuafernandes joshuafernandes temporarily deployed to no-secret May 9, 2022 21:22 Inactive
@joshuafernandes
Copy link
Contributor Author

Thankyou @rolandtyler :)

@joshuafernandes joshuafernandes deleted the k8s-v2 branch May 9, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants