Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating k8s monitoring charts #210

Merged
merged 3 commits into from
Apr 6, 2022
Merged

updating k8s monitoring charts #210

merged 3 commits into from
Apr 6, 2022

Conversation

joshuafernandes
Copy link
Contributor

@joshuafernandes joshuafernandes commented Apr 4, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

updating k8s monitoring charts

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@joshuafernandes joshuafernandes requested a review from a team as a code owner April 4, 2022 12:31
@joshuafernandes joshuafernandes temporarily deployed to preview April 4, 2022 12:31 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview April 4, 2022 12:34 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview April 4, 2022 12:40 Inactive
@joshuafernandes joshuafernandes temporarily deployed to preview April 4, 2022 12:45 Inactive
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, then LGTM

docs/tutorials/kubernetes/deploy-charts.md Outdated Show resolved Hide resolved
@joshuafernandes joshuafernandes temporarily deployed to preview April 6, 2022 11:52 Inactive
@joshuafernandes
Copy link
Contributor Author

One suggestion, then LGTM

👍 thankyou @alexandratran !

@joshuafernandes joshuafernandes temporarily deployed to preview April 6, 2022 11:52 Inactive
@joshuafernandes joshuafernandes merged commit 2705365 into Consensys:main Apr 6, 2022
@joshuafernandes joshuafernandes temporarily deployed to no-secret April 6, 2022 13:26 Inactive
@joshuafernandes joshuafernandes deleted the update-k8s-monitoring branch April 6, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants