Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify revert reason cli args behaviour #208

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

antonydenyer
Copy link
Contributor

Describe the change

Enabling the revert reason is done using cli args. The result will show up in eth_getTransactionReceipt without changing any params on the request.

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@antonydenyer antonydenyer requested a review from a team as a code owner March 28, 2022 13:38
@antonydenyer antonydenyer temporarily deployed to preview March 28, 2022 13:38 Inactive
@rolandtyler rolandtyler self-assigned this Mar 28, 2022
@rolandtyler rolandtyler temporarily deployed to preview March 28, 2022 13:42 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits, LGTM

@rolandtyler rolandtyler temporarily deployed to preview March 28, 2022 13:47 Inactive
@rolandtyler rolandtyler temporarily deployed to preview March 28, 2022 13:51 Inactive
@rolandtyler rolandtyler temporarily deployed to preview March 28, 2022 13:52 Inactive
@rolandtyler rolandtyler merged commit 1ea7210 into Consensys:main Mar 28, 2022
@rolandtyler rolandtyler temporarily deployed to no-secret March 28, 2022 13:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants