Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor note re consortium members and fixup of quickstart new node #207

Merged
merged 3 commits into from
Mar 22, 2022
Merged

minor note re consortium members and fixup of quickstart new node #207

merged 3 commits into from
Mar 22, 2022

Conversation

joshuafernandes
Copy link
Contributor

@joshuafernandes joshuafernandes commented Mar 22, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

  • Added notes re consortium members and validators
  • Fixed quickstart new node env var

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@joshuafernandes joshuafernandes requested a review from a team as a code owner March 22, 2022 21:55
@joshuafernandes joshuafernandes temporarily deployed to preview March 22, 2022 21:55 Inactive
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor rewording, otherwise lgtm

@joshuafernandes joshuafernandes temporarily deployed to preview March 22, 2022 22:47 Inactive
@joshuafernandes joshuafernandes enabled auto-merge (squash) March 22, 2022 23:05
@joshuafernandes joshuafernandes temporarily deployed to preview March 22, 2022 23:23 Inactive
@joshuafernandes joshuafernandes merged commit af4224d into Consensys:main Mar 22, 2022
@joshuafernandes joshuafernandes temporarily deployed to no-secret March 22, 2022 23:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants