Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qlight docs #203

Merged
merged 19 commits into from
Apr 8, 2022
Merged

Qlight docs #203

merged 19 commits into from
Apr 8, 2022

Conversation

SatpalSandhu61
Copy link
Contributor

@SatpalSandhu61 SatpalSandhu61 commented Mar 15, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Documentation for the qlight client.
Just draft for now, as the code PR is still also in draft.

Issue fixed

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 15, 2022 10:51 Inactive
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 15, 2022 16:33 Inactive
… qlight-docs

� Conflicts:
�	mkdocs.navigation.yml
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 16, 2022 11:42 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 16, 2022 11:49 Inactive
@baptiste-b-pegasys
Copy link
Contributor

Hi, in the diagram, why it's the org B's private state, in the attached note, only available from the org A QLight Node?
Should be org A's private state?

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 17, 2022 09:02 Inactive
@SatpalSandhu61
Copy link
Contributor Author

Hi, in the diagram, why it's the org B's private state, in the attached note, only available from the org A QLight Node? Should be org A's private state?

@baptiste-b-pegasys Good spot. I've corrected that.

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview March 18, 2022 17:27 Inactive
@NicolasMassart NicolasMassart temporarily deployed to preview March 18, 2022 17:31 Inactive
@nicolae-leonte-go nicolae-leonte-go temporarily deployed to preview April 5, 2022 14:03 Inactive
@nicolae-leonte-go nicolae-leonte-go temporarily deployed to preview April 5, 2022 14:11 Inactive
@nicolae-leonte-go nicolae-leonte-go temporarily deployed to preview April 6, 2022 08:40 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview April 6, 2022 14:16 Inactive
@NicolasMassart
Copy link
Member

Don't forget to create a 22.4.0 release of the doc once this PR is merged to match the GoQuorum 22.4.0 release: https://github.com/ConsenSys/doc.goquorum/releases/new

@SatpalSandhu61 SatpalSandhu61 marked this pull request as ready for review April 8, 2022 08:09
@SatpalSandhu61 SatpalSandhu61 requested a review from a team as a code owner April 8, 2022 08:09
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview April 8, 2022 08:46 Inactive
Copy link
Contributor

@antonydenyer antonydenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krish1979 Krish1979 enabled auto-merge (squash) April 8, 2022 10:06
@rolandtyler rolandtyler temporarily deployed to preview April 8, 2022 18:55 Inactive
@rolandtyler rolandtyler temporarily deployed to preview April 8, 2022 18:58 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some stylistic edits and links. LGTM

@Krish1979 Krish1979 merged commit 6ce0645 into Consensys:main Apr 8, 2022
@Krish1979 Krish1979 temporarily deployed to no-secret April 8, 2022 19:01 Inactive
@SatpalSandhu61 SatpalSandhu61 deleted the qlight-docs branch May 9, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants